-
-
Notifications
You must be signed in to change notification settings - Fork 142
feat(router)!: add route decorators #1695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@innocenzi changing the Route interface is a breaking change. The only mention in the docs about making your own route classes though is this: https://tempestphp.com/2.x/essentials/routing#group-middleware
How do you feel about it? Should we target 3.x? |
|
I decided to merge this for 2.8: a poll on Discord shows that there's only a handful of people who would be affected by the change, and I've added a rector to make it easier. The tl;dr is that Route classes must now also be writeable, so if they are declared |
Technically this is a breaking change because of how the
Routeinterface changed (addedsethooks).I don't think many people are relying on this, but I'm asking around on Discord first to be sure